Download Type Endpoint#44
Closed
ahmedelbatal1 wants to merge 2 commits into
Closed
Conversation
- Added DownloadType enum (Asset, Image) in CCE.Domain.Content.
- Created IDownloadService, AssetDownloadService, MediaDownloadService, and DownloadServiceFactory in CCE.Application.Content.Download.
- Created DownloadEndpointExtensions with shared MapDownloadEndpoints() in CCE.Api.Common.Extensions.
- Registered download services in DependencyInjection.cs.
- Replaced old asset download endpoints in External and Internal AssetEndpoints.cs with shared implementation.
- Replaced old media download endpoint in MediaPublicEndpoints.cs with shared implementation.
- External: /api/download/{id}?type=asset|image
- Internal: /api/admin/download/{id}?type=asset|image
Collaborator
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
dotnet test backend/CCE.slngreenpnpm nx run-many -t lint,testgreen./scripts/check-contracts-clean.shgreenpnpm nx run-many -t e2e(web-portal-e2e + admin-cms-e2e) greenSecurity checklist
BRD traceability
Screenshots / output (optional)